Add Azure App Service publishing auth fixtures#2110
Open
DENGXUELIN wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1717
Summary
Adds fixture-backed App Service publishing-plane basic authentication evidence handling to
azure-review.Changes include:
AZ-APP-PUBLISH-01throughAZ-APP-PUBLISH-08for App Service and slot inventory, SCM policy evidence, FTP policy evidence, slot parity, non-basic deployment replacement, credential invalidation, policy/audit coverage, and unsupported runtime-only evidencebasicPublishingCredentialsPolicies/scmandbasicPublishingCredentialsPolicies/ftpWhy
The existing #1718 and #1721 PRs add useful skill/checklist guidance, but neither adds local regression fixtures. This PR keeps the fix skill-local and adds concrete benign and vulnerable Terraform examples so future reviews distinguish runtime App Service controls from SCM/Kudu/WebDeploy/ZipDeploy and FTP publishing credential exposure.
Validation
git diff --check origin/main...HEADAZ-APP-PUBLISH-01throughAZ-APP-PUBLISH-08,App Service Deployment-Plane Basic Authentication Evidence,basicPublishingCredentialsPolicies/scm,basicPublishingCredentialsPolicies/ftp,webdeploy_publish_basic_authentication_enabled,ftp_publish_basic_authentication_enabled,AppServiceAuditLogs,configure-basic-auth-disable, andversion: "1.0.1"git merge-tree --write-tree origin/main HEADBounty
I have read and agree to the CONTRIBUTING.md bounty terms. Requested Improver Moderate tier if accepted.